Update simple_demo_qml coding style #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering5 #404 +/- ##
===============================================
Coverage 57.77% 57.77%
===============================================
Files 161 161
Lines 15947 15947
===============================================
+ Hits 9213 9214 +1
+ Misses 6734 6733 -1
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Sep 14, 2021
Signed-off-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
A follow up to #373
Made a few coding style changes to be consistent with rest of Ignition code base as mentioned in this comment
see 2c7ac93 for the coding style changes before renaming the files.
I didn't touch
ThreadedRenderer[.h|.cpp]as the code is mostly adapted from a Qt demo.The only non-style change I made is adding these two lines below to set the env variable as mentioned in this comment
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge